Re: [PATCH 2/2] bisect: string commands emited by "filter_skipped" together with "&&"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christian Couder <chriscool@xxxxxxxxxxxxx> writes:

> diff --git a/git-bisect.sh b/git-bisect.sh
> index a9324b2..08e31d6 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -296,14 +296,14 @@ filter_skipped() {
>  	do
> ...
>  	done
> +	echo ':'

Is there a particular reason you moved this echo ':' out of the downstream
of the pipe as I wrote in my response?

It logically belongs to the downstream in this pattern:

        producer of the list of items | {
                preparatory steps
                while read one item
                do
                        process one item
                        echo "something &&"
                done
                echo ":" ;# to conclude the && chain
        }

But you changed it to:

        preparatory step that does not concern producer

        producer of the list of items |
                while read one item
                do
                        process one item
                        echo "something &&"
                done

        echo ":"

which looks to me a lot less logical code structure.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux