Clarify the code a bit by consistently referring to the remote refs returned by transport_get_remote_refs() as remote_refs. Signed-off-by: Jay Soffian <jaysoffian@xxxxxxxxx> --- builtin-remote.c | 19 ++++++++++--------- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/builtin-remote.c b/builtin-remote.c index 48d668e..d5c808c 100644 --- a/builtin-remote.c +++ b/builtin-remote.c @@ -238,13 +238,14 @@ static int handle_one_branch(const char *refname, return 0; } -static int get_ref_states(const struct ref *ref, struct ref_states *states) +static int get_ref_states(const struct ref *remote_refs, struct ref_states *states) { struct ref *fetch_map = NULL, **tail = &fetch_map; + struct ref *ref; int i; for (i = 0; i < states->remote->fetch_refspec_nr; i++) - if (get_fetch_map(ref, states->remote->fetch + i, &tail, 1)) + if (get_fetch_map(remote_refs, states->remote->fetch + i, &tail, 1)) die("Could not get fetch map for refspec %s", states->remote->fetch_refspec[i]); @@ -271,7 +272,7 @@ static int get_ref_states(const struct ref *ref, struct ref_states *states) return 0; } -static int get_head_names(const struct ref *refs, +static int get_head_names(const struct ref *remote_refs, const char *remote_name, struct ref_states *states) { struct ref *ref, *matches = NULL; @@ -282,8 +283,8 @@ static int get_head_names(const struct ref *refs, refspec.pattern = 1; refspec.src = refspec.dst = "refs/heads/"; states->heads.strdup_strings = 1; - get_fetch_map(refs, &refspec, &fetch_map_tail, 0); - guess_remote_head(refs, fetch_map, NULL, &matches); + get_fetch_map(remote_refs, &refspec, &fetch_map_tail, 0); + guess_remote_head(remote_refs, fetch_map, NULL, &matches); for(ref = matches; ref; ref = ref->next) string_list_append(abbrev_branch(ref->name), &states->heads); @@ -667,7 +668,7 @@ static int get_remote_ref_states(const char *name, int query) { struct transport *transport; - const struct ref *ref; + const struct ref *remote_refs; states->remote = remote_get(name); if (!states->remote) @@ -678,11 +679,11 @@ static int get_remote_ref_states(const char *name, if (query) { transport = transport_get(NULL, states->remote->url_nr > 0 ? states->remote->url[0] : NULL); - ref = transport_get_remote_refs(transport); + remote_refs = transport_get_remote_refs(transport); transport_disconnect(transport); - get_head_names(ref, name, states); - get_ref_states(ref, states); + get_head_names(remote_refs, name, states); + get_ref_states(remote_refs, states); } return 0; -- 1.6.2.rc1.291.g83eb -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html