On Mon, Feb 23, 2009 at 01:29:00AM -0500, Jay Soffian wrote: > get_remote_ref_states() has three callers, but each is interested in > slightly different information. Give it a bit-field flag so that callers > can specify which pieces of information they need. Hmph. I think this is probably an indication that get_remote_ref_states() should really be 3 functions: common_stuff(); query_one(); query_two(); and then callers can choose the subset they are interested in. Which is really more or less equivalent; it just seems like extra obfuscation to have a single function with a bit-field. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
