Clarify the code a bit by consistently referring to the remote refs returned by transport_get_remote_refs() as remote_refs. Signed-off-by: Jay Soffian <jaysoffian@xxxxxxxxx> --- builtin-remote.c | 22 +++++++++++----------- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/builtin-remote.c b/builtin-remote.c index b61f754..df6b525 100644 --- a/builtin-remote.c +++ b/builtin-remote.c @@ -236,13 +236,14 @@ static int handle_one_branch(const char *refname, return 0; } -static int get_ref_states(const struct ref *ref, struct ref_states *states) +static int get_ref_states(const struct ref *remote_refs, struct ref_states *states) { struct ref *fetch_map = NULL, **tail = &fetch_map; + struct ref *ref; int i; for (i = 0; i < states->remote->fetch_refspec_nr; i++) - if (get_fetch_map(ref, states->remote->fetch + i, &tail, 1)) + if (get_fetch_map(remote_refs, states->remote->fetch + i, &tail, 1)) die("Could not get fetch map for refspec %s", states->remote->fetch_refspec[i]); @@ -264,7 +265,7 @@ static int get_ref_states(const struct ref *ref, struct ref_states *states) return 0; } -static int get_head_names(const struct ref *refs, +static int get_head_names(const struct ref *remote_refs, const char *remote_name, struct ref_states *states) { struct ref *ref, *matches; @@ -275,9 +276,9 @@ static int get_head_names(const struct ref *refs, refspec.pattern = 1; refspec.src = refspec.dst = "refs/heads/"; states->heads.strdup_strings = 1; - get_fetch_map(refs, &refspec, &fetch_map_tail, 0); - matches = guess_remote_head(find_ref_by_name(refs, "HEAD"), - fetch_map, 1); + get_fetch_map(remote_refs, &refspec, &fetch_map_tail, 0); + matches = guess_remote_head(find_ref_by_name(remote_refs, "HEAD"), + fetch_map, 1); for(ref = matches; ref; ref = ref->next) string_list_append(abbrev_branch(ref->name), &states->heads); @@ -678,7 +679,7 @@ static int get_remote_ref_states(const char *name, int query) { struct transport *transport; - const struct ref *ref; + const struct ref *remote_refs; states->remote = remote_get(name); if (!states->remote) @@ -689,11 +690,10 @@ static int get_remote_ref_states(const char *name, if (query) { transport = transport_get(NULL, states->remote->url_nr > 0 ? states->remote->url[0] : NULL); - ref = transport_get_remote_refs(transport); + remote_refs = transport_get_remote_refs(transport); transport_disconnect(transport); - - get_head_names(ref, name, states); - get_ref_states(ref, states); + get_head_names(remote_refs, name, states); + get_ref_states(remote_refs, states); } else { for_each_ref(append_ref_to_tracked_list, states); sort_string_list(&states->tracked); -- 1.6.2.rc1.223.gfed32 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html