Re: [PATCH/RFC 5/6] builtin-tag: add sort by date -D

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 22, 2009 at 8:06 PM, Marc-André Lureau
<marcandre.lureau@xxxxxxxxx> wrote:
> Signed-off-by: Marc-Andre Lureau <marcandre.lureau@xxxxxxxxx>
> ---
>  builtin-tag.c |  162 +++++++++++++++++++++++++++++++++++++++++++++------------
>  1 files changed, 129 insertions(+), 33 deletions(-)
>
> diff --git a/builtin-tag.c b/builtin-tag.c
> index 01e7374..8ff9d03 100644
> --- a/builtin-tag.c
> +++ b/builtin-tag.c
> @@ -16,7 +16,7 @@
>  static const char * const git_tag_usage[] = {
>        "git tag [-a|-s|-u <key-id>] [-f] [-m <msg>|-F <file>] <tagname> [<head>]",
>        "git tag -d <tagname>...",
> -       "git tag -l [-n[<num>]] [<pattern>]",
> +       "git tag -l [-n[<num>] -D] [<pattern>]",
>        "git tag -v <tagname>...",
>        NULL
>  };

Hmm, the -D option is independent of -n, so "[-D]". Also, it must be documented.

<snip/>

Wouldn't it make sense to split this patch so the first part adds the
option to filter, even if there are not filters functional, and the
second one adds the date filter?

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux