Hi
On Sun, Feb 22, 2009 at 8:21 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Marc-André Lureau <marcandre.lureau@xxxxxxxxx> writes:
>
>> ---
>> object.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/object.h b/object.h
>> index 89dd0c4..83d3644 100644
>> --- a/object.h
>> +++ b/object.h
>> @@ -21,7 +21,7 @@ struct object_array {
>> } *objects;
>> };
>>
>> -#define TYPE_BITS 3
>> +#define TYPE_BITS 4
>> #define FLAG_BITS 27
>
> This would increase the value of (TYPE_BITS+FLAG_BITS). We spent a lot of
> effect to keep sizeof(struct object) to absolute minimum, and you need to
> have a very good reason if you are breaking it.
>
>
Ooops. Ok, I should try to think harder how to have my own tag_list. I
only store a struct tag or a struct light_tag currently.
One option is to reuse the struct tag, by adding a "light" flag, but I
am not fond of this idea.
Second option is to create a custom tag list in builtin-tag.c, not
reusing object_list. I guess this is better then. What do you think?
For example:
struct tag_list {
struct object *item;
int light; /* item is a struct light_tag */
struct object_list *next;
}
thanks,
--
Marc-André Lureau
Sent from: Helsinki Southern Finland Finland.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
