On Sun, Feb 22, 2009 at 6:48 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> Doing so would be incoherent since --get-color would pick a color slot >> and ignore the variable type option (e.g. --bool), and the type would >> require a variable name. >> >> Suggested by Junio C Hamano. >> >> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> >> --- >> builtin-config.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/builtin-config.c b/builtin-config.c >> index 8045926..9930568 100644 >> --- a/builtin-config.c >> +++ b/builtin-config.c >> @@ -359,6 +359,11 @@ int cmd_config(int argc, const char **argv, const char *unused_prefix) >> if (get_colorbool_slot) >> actions |= ACTION_GET_COLORBOOL; >> >> + if ((get_color_slot || get_colorbool_slot) && types) { >> + error("--get-color and variable type are incoherent"); >> + usage_with_options(builtin_config_usage, builtin_config_options); >> + } >> + > > I do not think I suggested anything like this, so I'd decline to take > credit for this patch. > > Strictly speaking, "--bool --get-colorbool diff.color 1" shouldn't error > out, don't you think? And it certainly shouldn't say "--get-color". Huh? I misinterpreted: I see "git config --bool --get-color diff.color.whitespace" is still allowed, which you might want to tighten further. I don't really understand the --get-color* options, so please drop the patch. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html