Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
> --format=:foo is a shorthand for --pretty=tformat:foo, otherwise this
> new option acts just like --pretty=foo, except it's more intuitive for
> users of 'git log'.
It's been quite a long time since the earlier discussion, but I wonder why
you need the colon before "foo" for this new shorthand. I *think* you are
also introducing "--format=short" as a synonym to "--pretty=short", but
I do not think it is necessary.
> As discussed in the mailing list, this is implemented as an undocumented
> option.
Maybe somebody wants to document it.
Needs trivial tests.
> + } else if (!prefixcmp(arg, "--format=")) {
> + char *modified = NULL;
> + revs->verbose_header = 1;
> + if (arg[9] == ':') {
> + modified = xmalloc(strlen(arg+9) + 7 + 1);
> + strcpy(modified, "tformat");
> + strcat(modified, arg+9);
> + }
> + get_commit_format(modified ? modified : arg+9, revs);
> + free(modified);
struct strbuf fmt = STRBUF_INIT;
revs->verbose_header = 1;
strbuf_addf(&fmt, "tformat:%s", arg + 9);
get_commit_format(fmt.buf, revs);
strbuf_release(&fmt);
> } else if (!strcmp(arg, "--graph")) {
> revs->topo_order = 1;
> revs->rewrite_parents = 1;
> --
> 1.6.1.3
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
