Hi,
Disclaimer: if you are offended by constructive criticism, or likely to
answer with insults to the comments I offer, please stop reading this mail
now (and please to not answer my mail, either). :-)
Still with me? Good. Nice to meet you.
Just out of curiosity: why Cc: Marius? I would have expected Junio, Git's
maintainer.
May I suggest the commit subject to say "as for git log"? I mistook "a la
git log" for a change in the way git-blame works...
On Fri, 20 Feb 2009, eletuchy@xxxxxxxxx wrote:
> From: Eugene Letuchy <eugene@xxxxxxxxxxxx>
>
> Adds the following:
We try to use the imperative form; from my experience it makes for an
easier read: "Add the following:"
> - git config value blame.date that expects one of the git log date
> formats ({relative,local,default,iso,rfc,short})
> - git blame command line option --date-format expects one of the git
> log date formats ({relative,local,default,iso,rfc,short})
> - documentation in blame-options.txt
> - git blame uses the appropriate date.c functions and enums to
> make sense of the date format and provide appropriate data
>
> The tests pass. The mailmap test needed to be modified to expect iso
> formatted blames rather than the new "default".
IMHO the "The tests pass." should be removed.
Other than that, nicely done!
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
