Junio C Hamano wrote:
> Jakub Narebski <jnareb@xxxxxxxxx> writes:
>
> >> + $line =~ s{\b([0-9a-fA-F]{8,40})\b}{
> >> + return $cgi->a({-href => href(action=>"object", hash=>$1),
> >> + -class => "text"}, $1);
> >> + }eg;
> >> +
> >
> > Almost correct... but for this unnecessary 'return' statement.
> > Without it: ACK.
>
> I've applied this directly on 'master' without the return from inside s///e
> with your Ack. Please check the result.
I did quick test by installing newest gitweb (with above commit applied),
doing in gitweb searching commit message for '[a-f0-9]{8,40}' with regexp
search; everything looks all right. But I didn't do extensive tests.
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
