On Wed, Feb 18, 2009 at 4:30 PM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote: > > Nigel Magnay <nigel.magnay@xxxxxxxxx> wrote: > > +public class ObjectId extends AnyObjectId implements Serializable { > > We should define our own serialVersionUID: > > private static final long serialVersionUID = 1L; > > is good enough to make Java happy. I'll re-roll. Actually both that and the whitespace damage I'm partially blaming on eclipse. Eclipse curiously removes the warning to declare serialVersionUID if you declare both writeObject and readObject - that's wrong! Also the formatting came from .settings/org.eclipse.core.resources.prefs which has a tab policy of "Tabs only" which has overridden my environment setting of spaces-only. I can modify it to spaces only - but the comment in 9268ced9d38 talks about spaces-per-tab..? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html