Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> wrote:
> When bare repository handling is not enabled, check for a bare
> repository looking at the core.bare config option rather than refusing
> to operate with a git directory ending with .git.
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx>
> ---
> I know I should have probably used something like
> git rev-parse --is-bare-repository instead, but I didn't feel like
> adding another git call. Is the config approach robust enough?
>
> git-gui/git-gui.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
> index e018e07..658a728 100755
> --- a/git-gui/git-gui.sh
> +++ b/git-gui/git-gui.sh
> @@ -1071,7 +1071,7 @@ if {$_prefix ne {}} {
> }
> unset cdup
> } elseif {![is_enabled bare]} {
> - if {[lindex [file split $_gitdir] end] ne {.git}} {
> + if {[is_config_true core.bare]} {
This doesn't work as you expect. Its a chicken-and-egg problem.
We haven't read the config yet because we aren't sure that the
$_gitdir really is a git directory. Consequently, core.bare is
always false.
However, yes, in modern versions of git the core.bare setting in
.git/config is *usually* accurate.
The only time it isn't is when its not present (really old repository
which hasn't been re-init'd in a long time), or when the user does
"mv .git ../foo.git" to create a bare repository from a non-bare one.
;-)
--
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
