When I ran "make" in msysGit's /git/, I was greeted by a pretty unfriendly
message about a RUNTIME_PREFIX that could not be determined.
Not understanding the code in exec_cmd.c, I went back to a comment I made
to one of the iterations of the RUNTIME_PREFIX patch series (back when I
spent a considerable amount of time to understand the code), and turned it
into a patch myself.
I hope you will agree that the code introduced in 1/2 is more
understandable than what is removed in 2/2 in favor of the former.
The real meat comes in patch 2/2:
The problem is that Windows will look in the current directory before
looking in the PATH when it tries to execute a program. So it will find
the executable C:\msysgit\git\git.exe and be unable to strip the suffices
"libexec/git-core" or "bin".
I just added "git" (which should not hurt other users, but instead help
them if they did not install Git but run it in-place).
Johannes Schindelin (2):
Introduce the function strip_path_suffix()
system_path(): simplify using strip_path_suffix(), and add suffix
"git"
cache.h | 2 ++
exec_cmd.c | 32 +++-----------------------------
path.c | 33 +++++++++++++++++++++++++++++++++
3 files changed, 38 insertions(+), 29 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
