Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > In preparation for parseopt. I like this patch, because it clarifies what get_colorbool() and get_color() functions are meant to do by moving the boundary of responsibility between the two callers and these two functions. The above log message does not do justice to the patch text. > builtin-config.c | 63 +++++++++++++++-------------------------------------- > 1 files changed, 18 insertions(+), 45 deletions(-) I like a patch that results in code reduction, so I got quite interested in seeing what you did. But there was no magic --- you lost a lot of comments on what each function is supposed to do. They are all described in the documentation, and removal of these comments that can go stale is probably a good thing, but you could have avoided dissapointing me who expected a magic by mentioning the removal of the comments (and why it is a good idea) upfront ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
