Re: Improving CRLF error message; also, enabling autocrlf and safecrlf by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 15, 2009 at 07:14:30PM -0800, Junio C Hamano wrote:

> > I'm happy you want to improve git; but please, if you want to report
> > problems, check what the status is in a more recent version (or at least
> > tell us your version, which can help).
> > ...
> > It might be worth splitting the trailing whitespace detection into
> > "spaces and tabs at the end" and "CRLF", and providing different
> > messages (though it is hopefully also obvious with the new output that
> > it is a CRLF issue).
> 
> I think the status on this in a more recent version can be found by
> running "git grep cr-at-eol" ;-)

Heh. You didn't quote the part where I already claimed to be clueless.
;)

But seriously, might it not be useful for users seeing --check warnings
for the first time to print:

  file:1: trailing whitespace (cr-at-eol).
  +foo^M

That is, there are different rules for trailing whitespace, but we don't
currently tell you which one triggered. Giving the user "cr-at-eol"
gives them something to grep before.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux