On Sun, Feb 15, 2009 at 09:13:42PM +0100, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > > > + dir->show_ignored = !unset; > > > > + > > > > + return 0; > > > > +} > > > > > > Maybe this wants to be converted into an OPTION_BIT compatible data > > > type? > > > > I think that's not possible, as show_ignored is a bitfield. > > Well, in my juvenile folly I dreamt of turning this into a proper > bitfield... Uhm, I think I haven't got what you mean. ;-) Personally I would just remove all problematic bitfields in struct dir_struct as I think it does not worth using them, but getting rid of them just because of parseopt sounds insane as well - so I sended up writing callback functions, as you saw in the patch.
Attachment:
pgp9eMAv5IsRE.pgp
Description: PGP signature