On Sun, Feb 15, 2009 at 11:00:54AM +0200, Felipe Contreras wrote: > As suggested by Johannes Schindelin. Thank you for splitting this patch up. I have to admit I was too scared to read the original after seeing the diffstat. But part of the nice thing about splitting up is that you can write meaningful commit messages for each individual change. Reading this commit message, I don't know what to expect. Your 1/8, though short, tells me what to expect: a trivial rename. But "clean up config file handling" is quite ambiguous. And after reading the patch, I am left wondering why the filename and errno are not useful as part of the die() message. I think even a single sentence would probably make it clear. And yes, I know I can look elsewhere in the thread to find the discussion between you and Dscho. But think of the poor "git log" user six months from now. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
