Re: [PATCH] Make repack less likely to corrupt repository

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



söndag 15 februari 2009 17:46:59 skrev Johannes Schindelin:
> Hi,
> 
> On Sun, 15 Feb 2009, Robin Rosenberg wrote:
> > -	exit 1
> > +	echo >&2 "INFO: We recovered from the repack error, but your repo"
> > +	echo >&2 "INFO: is probably suboptimally packed. You may try to repack"
> > +	echo >&2 "INFO: later. A common reason for repacking failure is that"
> > +	echo >&2 "INFO: a Windows program was locking one of the old pack files."
> > +	echo >&2 "INFO: To repack successfully you may have to close that program"
> > +	echo >&2 "INFO: before repacking."
> 
> cat >&2 << EOF?

Yeah, but I followed the pattern from the warnings just prior to these messages.

> > +	exit
> 
> You lose the error condition here, but I cannot find a convincing argument 
> about that in the commit message.

I was thinking of my patch as an ammendment to Junios patch. In that context.

"Exit success if rollback fails after failing to rename old packs." Doesn't this
count?

-- robin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux