Re: [PATCH v3] send-email: --suppress-cc improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I just noticed that I lost the comments after '---' due to repeated
format-patch'ing, so here goes:

Thomas Rast wrote:
> From: Jay Soffian <jaysoffian@xxxxxxxxx>
> 
> Since 6564828 (git-send-email: Generalize auto-cc recipient
> mechanism., 2007-12-25) we can suppress automatic Cc generation
> separately for each of the possible address sources.  However,
> --suppress-cc=sob suppressed both SOB lines and body (but not header)
> Cc lines, contrary to the name.
> 
> Change --suppress-cc=sob to mean only SOB lines, and add separate
> choices 'bodycc' (body Cc lines) and 'body' (both 'sob' and 'bodycc').
> The option --no-signed-off-by-cc now acts like --suppress-cc=sob,
> which is not backwards compatible but matches the name of the option.
> 
> Also update the documentation and add a few tests.
> 
> Signed-off-by: Jay Soffian <jaysoffian@xxxxxxxxx>
> Signed-off-by: Thomas Rast <trast@xxxxxxxxxxxxxxx>
> ---

I tried to address Junio's comments, mostly by reformatting the docs
and expanding the tests, but also changing the handling of 'body' in
the code.  I also edited the patch message to my liking.

Of course your SOB above is now forged, so you'll have to ack it.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux