Hi, On Sat, 14 Feb 2009, Thomas Rast wrote: > The test used single quotes in the test code, but also single quotes > to wrap the entire test snippet, thus effectively skipping _out_ of > quoted mode. Since it doesn't matter here, just drop the quotes to > cause less confusion. ACK. > Also, the test passed a MSG variable to 'git notes show', but that > never calls an editor. That was actually what I tried to test by passing MSG=2... So I'd like to keep it. > As an aside, is there a specific reason why all the negative tests use > '! VAR=foo bar' instead of 'VAR=foo test_must_fail bar'? I thought the > latter was preferred to catch segfaults. I guess that back then when I wrote the first version of notes (which I hoped Johan Herland would take custody of), test_must_fail either did not exist or was too new for me to have picked up yet. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
