Re: [PATCH] send-email: handle multiple Cc addresses when reading mbox message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jay Soffian wrote:
> From: Jay Soffian <jaysoffian@xxxxxxxxx>
> 
> On Fri, Feb 13, 2009 at 6:32 PM, Thomas Rast <trast@xxxxxxxxxxxxxxx> wrote:
> > Jay Soffian wrote:
> >> -                     if (/^(Signed-off-by|Cc): (.*)$/i) {
> >> -                             next if ($suppress_cc{'sob'});
> > [...]
> >> +             if (/^(Signed-off-by|Cc): (.*)$/i) {
> >> +                     next if ($suppress_cc{'sob'});
> >
> > Doesn't this actually look like a long-standing send-email bug?  Since
> > 6564828 (git-send-email: Generalize auto-cc recipient mechanism.,
> > 2007-12-25) they should go in separate categories, but the above lines
> > were just translated from the old $signed_off_cc setting.  It seems
> > they should distinguish between SOB and Cc.
> 
> This is fixed by the last patch in this series. While I was working on
> it I noticed two other minor issues, which is the first two patches.

Thanks for the fix, and sorry if this was the comment that inspired
your venting earlier.  I should've tried a patch myself, but it was
already past midnight.  I'll send a slightly improved version of 3/3
shortly.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux