Jeff King <peff@xxxxxxxx> writes: > On Fri, Feb 13, 2009 at 06:02:56PM -0800, Junio C Hamano wrote: > >> > As it turns out, topgit is using refs/top-bases/ in HEAD, >> > leading us to re-loosen (at least temporarily) the >> > validate_headref check made in b229d18a. This patch does the >> > corresponding loosening for the symbolic-ref safety valve, >> > so that the two are in agreement once more. >> > >> > Signed-off-by: Jeff King <peff@xxxxxxxx> >> >> Actually we should simply revert afe5d3d5 altogether with the above >> message, as it introduced a test that expects the tightened behaviour. > > Is there any reason to throw away the "must be in refs/" safety valve, > though? That was the actual patch I started with and solved my problem, > and the "tighten to refs/heads/" bit came from discussion. That is, I > think having a safety valve in symbolic-ref that matches > validate_headref is orthogonal to how tightly validate_headref matches. > > But yes, I obviously failed to run the test suite on the follow-up patch > I sent. The final test in t1401 would need to be reverted, as well. Sure. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
