Johannes Schindelin wrote:
> On Fri, 13 Feb 2009, Thomas Rast wrote:
[...]
> > log-tree.c | 19 ++++++++++++++-----
> > log-tree.h | 3 +++
>
> I am slightly worried that you overshoot here, as log-tree.c has plumbing
> users, too, no?
>
> How about making this an option, and passing it in rev_opts instead? This
> option could then be defaulted to in git-log, when the user said
> --abbrev-commit.
But the 'git_config(git_log_config, NULL);' that sets the new variable
to false is only called from cmd_{log,show,whatchanged,reflog}. I
should have indicated this in the commit messaged, sorry.
The real problem with stuffing it in rev_opts (actually rev_info :-)
is that it seems inconsistent to not change the 'Merge: blah' line's
format. But that is generated in pretty.c, in add_merge_info via
pp_header from pretty_print_commit, which has a bunch of users in
various 'builtin-*.c'.
So do I sacrifice symmetry (abbrev_commit is indeed stored in
rev_info), or touch the other ~7 users of pretty_print_commit too?
--
Thomas Rast
trast@{inf,student}.ethz.ch
Attachment:
signature.asc
Description: This is a digitally signed message part.
