Re: [RFH] How to review patches: Documentation/ReviewingPatches?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, 13 Feb 2009, Junio C Hamano wrote:

> Marius Storm-Olsen <marius@xxxxxxxxxxxxx> writes:
> 
> > One thing I've wondered about though when sending patches, is how to 
> > send the fixups. Lets say I have a patch serie with 8 patches, do I 
> > send the whole serie each time, or do I just send an update to each 
> > individual patch? Do I attach it to the previous thread, or start a 
> > new one?
>
>  * Resending the whole series would help, especially if their earlier
>    round did not hit 'pu'.

Note that I chose to do it differently quite a number of times.  When I 
feel that a particular part of the patch series is in deep discussion 
mode, I will reply to the discussions with updates to that particular 
patch, often only as an interdiff.

When I feel that the result is in a shape that could be applied, or when I 
feel that people are substantially confused as to what is the current 
state, I send out a whole updated series.  This is to avoid sending 
v1..v99 of an 18-strong patch series, and basically dominate the volume of 
the list.

> Subsytem maintainers like Paulus for gitk, Shawn for git-gui and bash
> completion, Eric for git-svn, and Alexandre for emacs really have helped,

... and Jakub for gitweb, Simon for git-p4, Hannes for mingw.git, the New 
Zealand gang for cvsserver/cvsimport, not to forget Shawn for 
fast-import...  It is really great to see all that development going on!

Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux