On Fri, Feb 13, 2009 at 2:52 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jay Soffian <jaysoffian@xxxxxxxxx> writes: > >> This strikes me as premature optimization. > > It is *not* an optimization. It is reduction of code duplication to > improve maintainability before copy-and-paste gets out of hand. > > The proper adjective for it is not "premature" but "preemptive". I'll re-roll the patch again. However, if you look at the rest of builtin-branch.c, you'll see there are more places than that which are structured similarly (e.g. delete_branches). So if someone wanted to add another branch type, that would be the time (IMO), to refactor the statement at the top of append_ref(). j. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
