On Wed, Feb 11, 2009 at 2:03 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> @@ -339,7 +339,8 @@ while read commit parents; do >> eval "$filter_msg" > ../message || >> die "msg filter failed: $filter_msg" >> @SHELL_PATH@ -c "$filter_commit" "git commit-tree" \ >> - $(git write-tree) $parentstr < ../message > ../map/$commit >> + $(git write-tree) $parentstr < ../message > ../map/$commit || >> + die "could not write rewritten commit" > > Hmm, wouldn't commit-tree have issued its own error message already? If > redirect failed, then the shell would have. If a custom $filter_commit calls 'exit', there won't be an error message from git. Of course, there may be an error message from the custom $filter_commit, but I decided not to rely on that. Would you prefer me to remove the error message? I'll have another patch ready shortly, incorporating your suggestions. My apologies for giving credit in the wrong part of the commit message, and thank you for your feedback! Cheers, Eric -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
