The first patch has already been Acked by spearce. The second patch uses a consistent "if..." convention throughout the completion script. The third patch improves how the __git_ps1 works when (a) the CWD is a git dir and (b) when the CWD has a .git but no .git/HEAD. The fourth patch fixes unbound variable errors by replacing $__vars with ${__var-}s. Ted Pavlic (4): completion: For consistency, changed "git rev-parse" to __gitdir calls. completion: Use consistent if [...] convention. No test. completion: Better __git_ps1 support when not in working directory completion: More fixes to prevent unbound variable errors. contrib/completion/git-completion.bash | 75 ++++++++++++++++---------------- 1 files changed, 37 insertions(+), 38 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html