Ted Pavlic <ted@xxxxxxxxxxxxx> writes:
>> NAK.
>>
>> This script only runs in bash. bash supports [...]. The
>> prevailing convention in the script is to use [...]. Only
>> 4 tests inside of __git_ps1 use "test", the rest of the code
>> is using [...].
>
> So this trumps Documentation/CodingGuidelines, which says:
>
> - We prefer "test" over "[ ... ]".
>
> ?
No, this paragraph from Documentation/CodingGuidelines trumps you.
As for more concrete guidelines, just imitate the existing code
(this is a good guideline, no matter which project you are
contributing to). It is always preferable to match the _local_
convention. New code added to git suite is expected to match
the overall style of existing code. Modifications to existing
code is expected to match the style the surrounding code already
uses (even if it doesn't match the overall style of existing code).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
