Johannes Schindelin wrote: > On Sun, 8 Feb 2009, Marcel M. Cary wrote: >> Johannes Schindelin wrote: >>> On Fri, 6 Feb 2009, Marcel M. Cary wrote: >>>> While the "-P" option may be slightly less commonly supported than >>>> /bin/pwd, >>> Does this not suggest that your patch should at least fall back to >>> using /bin/pwd when it was detected that "cd -P" does not work? >> Having the "cd -P" strategy fall back to /bin/pwd negates most of the >> value I saw in using the simpler strategy. >> >> I haven't found cases where "cd -P" is more correct. > > Actually, it was not clear for me how much you researched the portability > of "cd -P". I have not. I've seen only that it's POSIX, is on BSD and Linux, and was suggested by Junio. > As long as it is not proven that your patch keeps working setups working, > I think you'll have to put in a bit more effort, research it, and then put > the discussion into the commit message. Actually, since I haven't heard any continued interest in following up with the suggestion to use "cd -P", I don't see much benefit myself, and there is concern about it not being compatible enough, I'm content to just table this. I agree that keeping working setups working is important, and it seems like a major project to research portability of "cd -P" on a list of platforms that I'm guessing I'd have to collect myself. Marcel -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
