On Mon, Feb 09, 2009 at 01:53:10PM -0500, Jeff King wrote:
> On Mon, Feb 09, 2009 at 01:09:22AM -0800, Junio C Hamano wrote:
>
> > This is a companion patch to the recent 3d95d92 (receive-pack: explain
> > what to do when push updates the current branch, 2009-01-31).
> >
> > Deleting the current branch from a remote will result in the next clone
> > from it not check out anything, among other things. It also is one of the
> > cause that makes remotes/origin/HEAD a dangling symbolic ref. This patch
> > still allows the traditional behaviour but with a big warning, and promises
> > that the default will change to 'refuse' in a future release.
>
> This patch looks good to me. One comment:
Actually, one more comment on this one. If a user tries to delete the
current branch in a non-bare repository, they actually get _both_
gigantic warning messages (one for denyCurrentBranch and one for
denyDeleteCurrent).
Should the denyCurrentBranch code be triggering at all on a deletion?
That is, if I have:
[receive]
denyCurrentBranch = refuse
denyDeleteCurrent = ignore
should such a deletion be refused or allowed?
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
