Mike Hommey <mh@xxxxxxxxxxxx> writes:
> On Sun, Feb 08, 2009 at 12:00:57PM -0800, Junio C Hamano wrote:
>> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
>>
>> > My preliminary guess is that this code in pack-write.c needs to use the
>> > lock file paradigm:
>> >
>> > if (!index_name) {
>> > [...]
>> > } else {
>> > unlink(index_name);
>> > fd = open(index_name, O_CREAT|O_EXCL|O_WRONLY, 0600);
>> > }
>>
>> Whoa. That particular code has been (and is still) correct.
>
> Don't both unlink and open fail in the case the index file is locked in
> Windows ?
Read the rest of the thread and read the code.
The index_file in question is not the file git-repack is telling
pack-write.c to unlink and open.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
