On Sat, Feb 7, 2009 at 11:14 PM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > Hi, > > On Sat, 7 Feb 2009, Felipe Contreras wrote: > >> On Thu, Feb 5, 2009 at 1:49 AM, Johannes Schindelin >> <Johannes.Schindelin@xxxxxx> wrote: >> > Hi, >> > >> > On Thu, 5 Feb 2009, Johannes Schindelin wrote: >> > >> >> On Wed, 4 Feb 2009, Junio C Hamano wrote: >> >> >> >> > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: >> >> > >> >> > > The idea was originated by discussion about usability of manually >> >> > > editing the config file in 'special needs' systems such as Windows. Now >> >> > > the user can forget a bit about where the config files actually are. >> >> > >> >> > Does this honor core.editor setting in existing configuration files? >> >> >> >> It should, as it uses launch_editor(). >> > >> > Oh, I see that launch_editor() does not do its own git_config() parsing. >> > Dunno if it should... >> >> I think it should, how expensive would it be to call >> git_config(git_default_config, NULL) when it has been loaded already? > > We would not need the complete git_default_config(), would we? Nope, just core.editor. But I don't know how to load only that. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html