More noise when parsing ref args?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Good day,

I heard a (quite valid) complaint on IRC about a confusing error
message. The command used was "git show <commit>:foo", where foo was a
working tree file in the CWD (a non-toplevel dir of the repository).
Obviously this couldn't have worked but the error message was the usual
"ambiguous argument" message output by verify_filename(). That message
doesn't really make clear the fact that the commit object was found but
the path wasn't. It's easy for someone with less experience to read the
message as "either the <commit> or the path suffix you gave was wrong".

It would be great adding another message that points out what exactly
went wrong in looking up the object, but that message would then appear
in plumbing. So what's the policy on adding new error messages to
plumbing? If it's a bad idea: I remember that a couple of months ago
some error handling code was changed to allow overloading messages from
porcelain. Can that be extended with a reasonable amount of effort?

-Jan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux