Re: [PATCHv2] gitweb: Better regexp for SHA-1 committag match

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> It would unfortunately falsely match... but we cannot eliminate this
> case (well, at least not checking if hexnumber is followed by dot),
> because of totally legitimate
>
>    ... at commit 8457bb9e.
>
> So even with that we would have still false matches...

Yeah, so what's the value in v2 over v1?  It is still wrong but it is less
wrong than it used to be?  I think the word-boundary one made a good
sense.  I do not see the @lookahead adding much value at all.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux