On Wed, Feb 04, 2009 at 12:26:26AM +0100, Johannes Schindelin wrote: > It does not make much sense to run the (expensive) valgrind tests and > not look at the output. > > To prevent output from scrolling out of reach, the parameter --tee is > implied, too. Might it not make sense to want to send the output to a file, but _not_ show it on the terminal (e.g., running from a cron job)? But if I understand correctly, that is not actually possible with any combination of "--verbose" and "--tee". So perhaps it would make more sense to have, rather than "--tee", simply "--verbose" to output to the terminal and "--save-output" (or similar) to save the output. If both are requested, it is equivalent to what "--tee" does now. On the other hand, I think "--verbose --tee >/dev/null" would probably accomplish the same thing, so it probably isn't worth too much effort. Other than that, this series looks pretty reasonable. I am a bit late to ack, but thank you for following through on it. It looks like it has caught some bugs already, which is always a good sign. :) I have access to a decent quad-core box, so I'll try to periodically run the test suite with valgrind on it. Daily is probably too much, but maybe whenever we go into rc-freeze is a good time. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
