On Wed, Feb 4, 2009 at 11:56 PM, Jakub Narebski <jnareb@xxxxxxxxx> wrote: >> + if (defined $logo || defined $favicon) { >> + # prefer the logo to the favicon, since RSS >> + # doesn't allow both >> + my $img = esc_url($logo || $favicon); >> + print "<image>\n" . >> + "<url>$img</url>\n" . >> + "<title>$title</title>\n" . >> + "<link>$alt_url</link>\n" . >> + "</image>\n"; >> + } > > A question: how should URL, which is _contents_ of a tag (instead of > as _attribute_ value), quoted (escaped)? I don't think it is specified > in RSS. I guess that using esc_url() is a safe solution. Indeed, it might not be needed, but it's doesn't do any damage to escape the URL. -- Giuseppe "Oblomov" Bilotta -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html