Shawn O. Pearce wrote:
> Tor Arne Vestbø <torarnv@xxxxxxxxx> wrote:
>> + public static synchronized void removeRepositoryChangeListener(
>> + final RepositoryChangeListener objectThatCares) {
>> + repositoryChangeListeners.remove(objectThatCares);
>> }
>>
>> /**
>> @@ -131,13 +133,8 @@ public static synchronized void addRepositoryChangeListener(
>> * the repository which has had changes occur within it.
>> */
>> static void fireRepositoryChanged(final RepositoryMapping which) {
>> - final RepositoryChangeListener[] e = getRepositoryChangeListeners();
>> - for (int k = e.length - 1; k >= 0; k--)
>> - e[k].repositoryChanged(which);
>> - }
>> -
>> - private static synchronized RepositoryChangeListener[] getRepositoryChangeListeners() {
>> - return repositoryChangeListeners;
>> + for (RepositoryChangeListener listener : repositoryChangeListeners)
>> + listener.repositoryChanged(which);
>
> See anything wrong here, like that the Set can be modified while
> GitProjectData's class lock is held, but its being read here without
> any locking?
You're perfectly right. New patch coming up!
Tor Arne
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
