Hi, On Tue, 3 Feb 2009, Toralf Förster wrote: > At Monday 02 February 2009 23:54:20 Jakub Narebski wrote : > > Toralf Förster <toralf.foerster@xxxxxx> writes: > > > As seen here > > > http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.27.y.git;a=com > > >mit;h=8ca2918f99b5861359de1805f27b08023c82abd2 the strings [<c043d0f3>] > > > and firends shouldn't be recognized as git hashes, isn't it ? > > > > Gitweb, not webgit. And gitweb considers ([0-9a-fA-F]{8,40}) i.e. > > from 8 to 40 hexadecimal characters to be (shortened) SHA-1. It > > simply cannot afford checking if such object exists when displaying > > commit message (for example in 'log' view). > > Ah - ok, what's about expecting spaces around such SHA-1 keys ? Won't fly: there was a recommendation at some point that you should refer to commits in such a form: 2819075(Merge branch 'maint-1.6.0' into maint) However, gitweb being written in Perl, I think a lookbehind like (?<!0x), i.e. that a 0x in front of the hexadecimal characters means it is no SHA-1. Even better would be using word boundaries, I guess, but all that fails when you have a hexdump in the commit message. Ciao, Dscho
