Re: [PATCH,v2] git-bundle(1): add no references required simplest case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 2 Feb 2009, jidanni@xxxxxxxxxxx wrote:

> Words totally by Junio C Hamano.
> Signed-off-by: jidanni <jidanni@xxxxxxxxxxx>
> ---
> 
> Junio: I used your words.
> You might have missed this patch. Resending.

You are not serious, are you?  People have explained time and time again 
what is required by a commit message.

Now, I am not a native speaker, but the commit subject seems to contain 
grammatical errors.  Even if it weren't, it is not understandable.

So the only thing that is in your complete commit message remotely 
purporting to explain what the patch is about and why it is good, fails to 
do so.

Also, we always have an empty line before SOB lines.

> +A complete bundle is one that does not require you to have any

I have not heard of any "complete" bundle before, and I do not understand 
the need for such a definition, either.

> +prerequisite object for you to extract its contents.  Not only you
> +can fetch/pull from a bundle, you can clone from a complete bundle

"Not only you can" violates grammar in my book.

> +as if it was a remote repository, like this:
> +
> +----------------
> +$ git clone /home/me/tmp/file.bdl mine.git
> +----------------
> +
> +This will define a remote called "origin" in the resulting
> +repository that lets you fetch and pull from the bundle, just
> +like the previous example lets you do with the remote called
> +"bundle", and from then on you can fetch/pull to update the
> +resulting mine.git repository after replacing the bundle you store
> +at /home/me/tmp/file.bdl with incremental updates.

IMO this paragraph just adds words, not anything the user does not know 
already by that stage.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux