Robin Rosenberg <robin.rosenberg@xxxxxxxxxx> wrote: > This commit restores the ability to filter on not only the selected > resource but instead all changes in the same folder, same project > or same repository. The filtering levels supported are Resource (no button > pessed), Folder, Project and Repository. Only the highest level has any > effect. The flags are persistent between eclipse sessions in the same > workspace. Shouldn't these filtering flag buttons be exclusive buttons, in the sense that only one can be depressed at a time, or none are depressed? I managed to depress R,P,F by doing it in the opposite order (push F, then P, then R) and I have no clue what that should really mean when looking at the history. Also, the R/P/F labels are a bit too similar. I know its what we had before, but these are blending too much to me visually and I keep reading the F as though it were a misdrawn R or P, like the box isn't big enough for it. Which actually has me thinking that with the proportional width font on my workbench the F is using a narrower button box than the R or P, which looks funny. > diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/GitHistoryPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/GitHistoryPage.java > index d718cd7..4e95df4 100644 > --- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/GitHistoryPage.java > +++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/GitHistoryPage.java > @@ -96,7 +96,7 @@ > > /** > * Determine if the input can be shown in this viewer. > - * > + * > * @param object > * an object that is hopefully of type ResourceList or IResource, > * but may be anything (including null). Unnecessary re-formatting hunk. Please discard from the patch. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
