Hi, On Fri, 30 Jan 2009, Geoffrey Thomas wrote: > Currently, however, printf("%*.*s", width, width, author) is simply > wrong, because printf only cares about bytes, not screen columns. Do you > think I should fall back on the old behavior if i18n.commitencoding is > set, or if at least one of the author names isn't parseable as UTF-8, or > something? Or should I be doing this with iconv and assuming all commits > are encoded in the current encoding specified via $LANG or $LC_whatever? I do not know what encoding the author is at that point, but if you cannot be sure that it is UTF-8, using utf8_strwidth() is just as wrong as the current code, IMHO. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html