Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes: > Junio C Hamano schrieb: >> By default we looked at all refs but not HEAD. The only thing that >> made fsck not lose sight of comments that are only reachable from a >> detached HEAD was the reflog for the HEAD. >> >> This fixes it, with a new test. > [...] >> +test_expect_success setup ' >> + test_commit A && >> + git checkout HEAD^0 && >> + test_commit B && >> + git reflog expire --expire=now --all >> +' >> + >> +test_expect_success 'HEAD is part of refs' ' >> + test 0 = $(git fsck | wc -l) > > I'm scratching my head over this. This test succeeds even without the > change... (Tested with a34a9db.) You are right. I forgot that test_commit creates an extra tag. By adding git tag -d B && after "test_commit B &&", you would expose the issue in the existing code. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
