On Fri, Jan 30, 2009 at 11:35:50AM -0700, Elijah Newren wrote: > > 2009/1/30 Elijah Newren <newren@xxxxxxxxx>: > >> [5] The bug I can only occasionally trigger and which I don't know the > >> cause of yet: when exiting from eg log the terminal settings sometimes > >> are messed up (with echo off and such), requiring a "reset" to get the > >> terminal back to normal. > > > > Are you sure that isn't this bug in git.git ? > > > > pager: do wait_for_pager on signal death > > http://article.gmane.org/gmane.comp.version-control.git/106728 > > Interesting. I just went and tried out next (git version > 1.6.1.2.418.gd79e6), which I believe has this patch...and after a > while I was still able to duplicate the eg bug on one of my > machines[1]. So it doesn't seem to be that particular issue, at > least. There is also a related set of fixes for spawning externals via fork, which fixes a bug with the pager not getting cleaned up. But it looks like it is also in the version you tested. Can you give a more complete recipe for reproducing? Since I was just touching this area in git, I want to make sure it isn't a git bug you are triggering. :) As an aside, I found some related weirdness. In my git repo, if I do this: $ git checkout next $ eg log -p I get log output, but the diff is not colorized (and I have color.diff set to "auto" in my ~/.gitconfig). But if I detach my HEAD and show the log: $ git checkout next^0 $ eg log -p then I _do_ get color in the patch. I also get this error: Use of uninitialized value $branch in concatenation (.) or string at /home/peff/eg line 2854. eg: command (git rev-parse refs/heads/) failed eg: received signal 13 The error is easy to explain. The offending code is: my $branch = RepoUtil::current_branch(); my ($ret, $revision) = ExecUtil::execute_captured("git rev-parse refs/heads/$branch"); So it is clear that you just need to handle the case of there being no current branch. But the color thing is certainly exotic. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
