Hi folks, quick update about the state of blame functionality in my egit branch at http://github.com/manuel-woelker/egit/tree/blame Screen shot here: http://docs.google.com/View?docid=df5rvczr_3f46vd2ds - Diff support: I changed the IDiff as suggested to work on raw bytes and IntList's. I also yanked the Diff implementation from wicket and adapted it for use in jgit. The diff stuff now lives in its own package. I also added some basic tests to see if plugged diff implementations conform to the required expectations. - log support: I added an OriginWalk in the new log package that traces ancestry of a file though history (including renames and copying). This might also be neat for the history page, which does not seem to follow renames at the moment (think "log -C -M"). This is just a rough sketch atm. Copies are disabled right now, cause the performance is abysmal, and the current implementation tries to trace the ancestry of empty lines back to the triassic period. So this could definitely be optimized. The OriginWalk itself uses RevObject (as suggested) so it should be a little faster. The implementation currently traces the different strands of ancestry quite naively, possibly parsing commits multiple times. This could be improved to a single pass walk, but this makes the algorithm a little less straight-forward and I haven't gotten around to that. - As a result of the the OriginWalk mentioned above, the blame implementation has been refactored slightly, while still keeping the basic structure. - I hooked up the blame functionality to the UI which was easier than anticipated. I am quite pleased with the result (see screen shot above). The only thing that proved a little tricky was history and annotation ruler selection listener notifying each other recursively. For now I stopped the stack overflow by detecting that recursive call. If anyone got a better solution just give me a shout. Feedback, comments and criticism are welcome as always. Cheers - Manuel -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
