Hi, On Thu, Jan 29, 2009 at 6:51 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > What's with these loooooooooooooooooooooooooooooong lines? > > I thought at least you did not have these overlong lines in your earlier > attempts, and Dscho may have acked one of those, but I doubt he would give > his Ack to this one. I certainly wouldn't Ack it myself. > > By the way, aren't you sending format="flowed"? Please don't. It damages > whitespaces. I used Thunderbird since Gmail kept wrapping lines in the patch, guess i"ll have to manually wrap the commit lines. > Daniel Stenberg did a research on the safety of your "since curl stdrup's > it" claim, and found that it unsafe for earlier versions of the library > before 7.17.0. > > It seems that we earlier found out that anything older than 7.16 were not > usable for git-http-push (see Release Notes for 1.5.4), but 7.16 is still > older than 7.17, so either we declare you _must_ have 7.17 or newer to use > http-push, or keep an extra copy around and free it later like the > original code does. > > Even Debian is at 7.18.2 these days, so requiring 7.17 or newer may not be > an issue in practice, but there are people who keep running things on > older distros with proven stability (and known features limitation). > > The refactoring looked sane otherwise, but I think we would want to opt > for safety by keeping an extra string around. Hmm, since that string won't be released in start_fetch_loose, or anywhere else, would this be considered a memory leak? -- Cheers, Ray Chuan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
