Re: [JGIT PATCH] Add getTaggerIdent, getShortMessage, getFullMessage to RevTag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



onsdag 28 januari 2009 05:35:16 skrev Shawn O. Pearce:
> These methods make the RevTag API more like the RevCommit API, such
> that it is more consistent for applications to access the "fields"
> of a tag object in the same way that they access the fields of any
> commit object.
> 
> Signed-off-by: Shawn O. Pearce <spearce@xxxxxxxxxxx>
> ---
> 
>  Actually, this has also gone through Gerrit2.  If you want to see
>  what the same patch looks like (just for fun):

The reviewer is biased :) Where are the unit tests?

I'm kind of surprised you did not optimized skipping past the object header,
like the parents are skipped when parsing commits.

-- robin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux