Hi, On Mon, 26 Jan 2009, Ray Chuan wrote: > On Mon, Jan 26, 2009 at 4:35 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> @@ -304,17 +312,7 @@ static void start_fetch_loose(struct > >> transfer_request *request) > >> > >> git_SHA1_Init(&request->c); > >> > >> - url = xmalloc(strlen(remote->url) + 50); > >> ... > >> - strcpy(request->url, url); > >> + request->url = get_remote_object_url(remote->url, hex, 0); > >> ... > >> - curl_easy_setopt(slot->curl, CURLOPT_URL, url); > >> + curl_easy_setopt(slot->curl, CURLOPT_URL, request->url); > > > > The original code gave a separate "url" to setop() but this gives the same > > string. Does curl_easy_setop() copies the given string away? IOW is this > > change safe? > > > > curl strdup's it, so this is safe. I might have mentioned that things like this _need_ to go into the commit message. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
