Re: [PATCH 08/10] run test suite without dashed git-commands in PATH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat, 24 Jan 2009, Matthew Ogilvie wrote:

>  .gitignore          |    1 +
>  Makefile            |   42 +++++++++++++++++++++++++++++++-----------
>  t/test-lib.sh       |   14 +++++++++++++-
>  test-bin-wrapper.sh |   12 ++++++++++++
>  4 files changed, 57 insertions(+), 12 deletions(-)
>  create mode 100644 test-bin-wrapper.sh

I am strongly opposed to a patch this big, just for something as 3rd class 
as CVS server faking.  We already have a big fallout from all that bending 
over for Windows support, and I do not like it at all.

Note: I do not even have to look further than the diffstat to see that it 
is wrong.

The point is: if cvsserver wants to pretend that it is in a fake bin where 
almost none of the other Git programs are, fine, let's do that _in the 
test for cvsserver_.

Let's not fsck up the whole test suite just for one user.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux