On Sat, Jan 24, 2009 at 20:42, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > This existing one says "If 'uname -r' output does not begin with two > characters '9.' (nine and dot), then set OLD_ICONV". > > I am guessing that 'uname -r' says 9.X in "Darwin 9.X" (which is OSX > 10.5), and existing conditional says that versions before 9.X needs > OLD_ICONV but later ones do not need it. Yeah, that's because versions before 10.5 aka darwin 9 aka "Leopard" have a broken iconv implementation. > Does 1.X stand for OSX 10.2? A quick googling finds a handful pages that > say that OSX 10.2 = Darwin 6.x and OSX 10.3 = Darwin 7.x, and I am not > sure where you are getting that "begins with one-and-dot" from.... I've got my information from [1]. It says: darwin 1.3 => OSX 10.0 darwin 1.4 => OSX 10.1 darwin 6 => OSX 10.2 darwin 7 => OSX 10.3 etc. I don't know why they chose this weird versioning scheme, but wait, it gets even crazier darwin 1.4.1 => OSX 10.1 darwin 5.1 => OSX 10.1.1 So my patch checks only for 10.1 but not for 10.1.1 *sigh* - NO_STRLCPY = YesPlease + ifeq ($(shell expr "$(uname_R)" : '[015]\.'),2) + NO_STRLCPY = YesPlease + endif Should get all darwin versions before 6.0 in which strlcpy(3) was introduced. Thanks for your patience ;) --------------- [1] http://www.opensource.apple.com/darwinsource/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
