Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> Hi,
>
> On Sat, 24 Jan 2009, Ray Chuan wrote:
>
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
>
> Make that an Acked-by:
>
>> + if(options & DAV_HEADER_IF) {
>> + strbuf_addf(&buf, "If: (<%s>)", lock->token);
>> + dav_headers = curl_slist_append(dav_headers, buf.buf);
>> + strbuf_reset(&buf);
>
> BTW in case anyone is puzzled (like I was): curl_slist_append() takes a
> "char *" as second parameter, but does not take custody of the buffer;
> instead, it strdup()s it. See
> http://cool.haxx.se/cvs.cgi/curl/lib/sendf.c?rev=1.155&content-type=text/vnd.viewcvs-markup
> for details.
>
> BTNW this should be mentioned in the commit message, too, to spare other
> people the puzzlement.
Yeah, but your advice is too late --- I already lost a few minutes solving
my puzzlement with manpages.
Thanks, both.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
